-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): output selector #1419
Merged
thibault-martinez
merged 28 commits into
iotaledger:develop
from
Alex6323:feat/cli/output-selector-2
Oct 18, 2023
Merged
feat(cli): output selector #1419
thibault-martinez
merged 28 commits into
iotaledger:develop
from
Alex6323:feat/cli/output-selector-2
Oct 18, 2023
+88
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thoralf-M
reviewed
Oct 11, 2023
Alex6323
force-pushed
the
feat/cli/output-selector-2
branch
from
October 16, 2023 07:38
6893c04
to
0c7828f
Compare
thibault-martinez
requested changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog
Co-authored-by: Thibault Martinez <[email protected]>
Alex6323
force-pushed
the
feat/cli/output-selector-2
branch
from
October 16, 2023 14:13
1532d2e
to
b87e61a
Compare
Alex6323
force-pushed
the
feat/cli/output-selector-2
branch
from
October 17, 2023 15:45
4f53ffc
to
1d128a0
Compare
Co-authored-by: DaughterOfMars <[email protected]>
If you still have some time you can fix if you want. Thx |
Co-authored-by: Thibault Martinez <[email protected]>
thibault-martinez
approved these changes
Oct 18, 2023
DaughterOfMars
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Changes the
output
command to expect anOutputSelector
which allows to select an output in the account/wallet by providing either the correspondingoutput id
or itsindex
in the list of all account/wallet outputs. It works just like theTransactionSelector
we already have.Links to any relevant issues
Closes #1319
Type of change
How the change has been tested
Not (yet)